-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add analytics models and tests #117
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilderlane
commented
Oct 3, 2023
- Add Ad account analytics and its integration tests
- Add Ad groups analytics and its integration tests
- Add Ads analytics and its integration tests
- Add Campaigns analytics and its integration tests
- Add Pin analytics and its integration tests
- Update board and pin models with new properties
* Analytics base model outline and fields * Fix lint errors
* AnalyticsUtils _get_ad_entity_analytics helper method * Implement get_analytics() for AdAccount model * Make the helper function get_ad_entity_analytics public
* New setup for documentation (#42) * Remove old doc and Sphinx (#33) * Add documentation generator - `lazydocs` (#36) * Add lazydocs and script to generate spec file * Add skeleton spec and script to generate doc * Add comments and readme * Update README.md * Update format and comments Co-authored-by: Rushabh Varia <[email protected]> * add overview file and update script * Update script logic (#39) * Update script to work with overview file * Remove function * Generate documentation using script.py (#41) * Generate doc using script.py * Add update ignored files * Regenerate with organics * Link overview file to README.md * Add ignore module for lazydocs (#44) * Add ignore module for lazydocs * Add emtpy file to ignore list * Run doc gen script * Correct base_url * Regenerate Co-authored-by: Rushabh Varia <[email protected]> * remove: beta message from README.md (#50) * Change generated client package name and version (#52) * feat(dependecy): change generated client package name and version * change(lint): fix lint issue (#53) * feat(version): change release (#55) * Update contact info and source_base_url (#57) * Update contact info * Update source_base_url * Regen * Point to doc page on devsite (#58) * Add actions to test and publish artifact (#59) * feat(ci): add test publish action * feat(ci): add github action to publish to pypi * fix: linter (#60) * Analytics base model outline and fields (#34) * Analytics base model outline and fields * Fix lint errors * Ad Account `get_analytics` (#40) * AnalyticsUtils _get_ad_entity_analytics helper method * Implement get_analytics() for AdAccount model * Make the helper function get_ad_entity_analytics public * fix: merge conflict Co-authored-by: Thuc Nguyen <[email protected]> Co-authored-by: Rushabh Varia <[email protected]>
* feat(analtics): add get_targeting_analytics to ads * feat(analytic): fix lint * fix: linter
* feat(analytic): add analytics ad group * Update ad_groups.py
* feat(ads): add get analytics function
* feat: add get pin analytic * fix campaigns param * Add missing line * fix ad_entity ad group * refactor: change param and method name
* AnalyticsUtils _get_ad_entity_analytics helper method * Implement get_analytics() for AdAccount model * Make the helper function get_ad_entity_analytics public
* feat: add get pin analytic * fix campaigns param * Add missing line * fix ad_entity ad group * refactor: change param and method name
… feature-dev/analytics-models
…erting error is raised
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.